NPE when creating a site with a templates set for which the templates.xml file contains not home page template

504 r22041 (HotFix)

When creating a new virtual site, I have encountered NPE. When I have verified the content of the templates.xml file, I have found that no template was set as the home page template. The problem is that my site creation has failed, and so it is out of use. I think it would be bettter to use first template in the list in such a case, and add an error message in log to inform that a template has automaticaly be chosen as the default one. Then, if it is not the good one, it is still possible to switch the used template in page settings, whereas currently, we can do no other thing than dropping the site.

2008-09-18 10:43:22,214: INFO [org.apache.slide.security.SecurityImpl] - Action aggregations loaded successfully
java.lang.NullPointerException
at org.jahia.admin.sites.ManageSites.getHomePageDefinition(ManageSites.java:1324)
at org.jahia.admin.sites.ManageSites.terminateAdd(ManageSites.java:1029)
at org.jahia.admin.sites.ManageSites.createSite(ManageSites.java:1573)
at org.jahia.admin.sites.ManageSites.userRequestDispatcher(ManageSites.java:207)
at org.jahia.admin.sites.ManageSites.<init>(ManageSites.java:154)
at org.jahia.bin.JahiaAdministration.userRequestDispatcher(JahiaAdministration.java:401)
at org.jahia.bin.JahiaAdministration.service(JahiaAdministration.java:266)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at org.jahia.bin.filters.esi.ESIFilter.doFilter(ESIFilter.java:110)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178)
at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:432)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148)
at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869)
at org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:664)
at org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527)
at org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80)
at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684)
at java.lang.Thread.run(Thread.java:619)
2008-09-18 10:43:26,715: ERROR [org.jahia.admin.sites.ManageSites] - Error while adding site