Uploaded image for project: 'Jahia Community'
  1. Jahia Community
  2. JAHIA-3184

SP4: Do not forget to remove Corpv1 and Test-Units templates + refactor the boxes and default templates

Details

    • Bug
    • Resolution: Done
    • Major
    • xCM 5.0 SP4
    • xCM 5.0 SP4
    • None
    • SP4 21050

    Description

      For the final SP4 release, do not forget to:

      • remove all Corpv1
      • remove the test-units templates
      • refactor the template.xml in order to remove extra templates and boxes.

      TestRail: Results

        Attachments

          Activity

            [JAHIA-3184] SP4: Do not forget to remove Corpv1 and Test-Units templates + refactor the boxes and default templates

            I think the GC verbose will actually help us understand what is going on in production servers. I agree that are not beautiful, but neither our our logs

            shuber_old Serge Huber (Inactive) added a comment - I think the GC verbose will actually help us understand what is going on in production servers. I agree that are not beautiful, but neither our our logs

            The /corporate_portal_templates_v2/src/jsp/common/top_declarations.inc still contains declarations for Document Listing template and filters/sorters for unused templates. These filters/sorters just use resources (and decrease the performance) and unneeded container declarations (doc listing) on the home page.

            I would REMOVE (not comment out) all unused templates (as we did for 5.0 SP3) as the garbage that is left after them will never be removed by the template developer (as nobody really understand what should be included exactly).

            We should deliver a production-ready set of template as many customers will use them without any modifications.
            And if additional templates are needed, they are always available from our online repository.

            I would also disable the verbose garbage collection for the same reason - we are delivering a ready for production server and not the dev. environment. Many customers do not even know, how to disable it Customers even more lazy than developers. nobody will clean up templates
            Or our vision has changed and we indeed would like to build the complete development release but with some commented out templates?

            What do you think?

            It could be that this was already discuissed (developer meeting or architect meeting?) and I have missed it and just asking silly questions?
            In this case excuse me in advance, please, for spreading panic

            shyrkov Sergiy Shyrkov (Inactive) added a comment - The /corporate_portal_templates_v2/src/jsp/common/top_declarations.inc still contains declarations for Document Listing template and filters/sorters for unused templates. These filters/sorters just use resources (and decrease the performance) and unneeded container declarations (doc listing) on the home page. I would REMOVE (not comment out) all unused templates (as we did for 5.0 SP3) as the garbage that is left after them will never be removed by the template developer (as nobody really understand what should be included exactly). We should deliver a production-ready set of template as many customers will use them without any modifications. And if additional templates are needed, they are always available from our online repository. I would also disable the verbose garbage collection for the same reason - we are delivering a ready for production server and not the dev. environment. Many customers do not even know, how to disable it Customers even more lazy than developers. nobody will clean up templates Or our vision has changed and we indeed would like to build the complete development release but with some commented out templates? What do you think? It could be that this was already discuissed (developer meeting or architect meeting?) and I have missed it and just asking silly questions? In this case excuse me in advance, please, for spreading panic

            Should be ok by now

            rfelden Romain Felden (Inactive) added a comment - Should be ok by now

            Actually it would be better to keep the GC messages since customers often have memory issues, so tracking would be easier.

            I'm going to remove these JARs and clean the template.xml file.

            rfelden Romain Felden (Inactive) added a comment - Actually it would be better to keep the GC messages since customers often have memory issues, so tracking would be easier. I'm going to remove these JARs and clean the template.xml file.

            Perhaps we could also remove doc_templates.jar from the nightly build and remove the verbose garbage collector messages (-verbose:gc) from catalina.bat and catalina.sh?

            shyrkov Sergiy Shyrkov (Inactive) added a comment - Perhaps we could also remove doc_templates.jar from the nightly build and remove the verbose garbage collector messages (-verbose:gc) from catalina.bat and catalina.sh?

            People

              rfelden Romain Felden (Inactive)
              scroisier Stephane Croisier (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                TestRail: Runs

                  TestRail: Cases

                    Packages

                      Version Package
                      xCM 5.0 SP4